Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai: Car Port for Nexo 2021 #29771

Closed
wants to merge 27 commits into from

Conversation

sunnyhaibin
Copy link
Contributor

@sunnyhaibin sunnyhaibin commented Sep 4, 2023

Checklist

  • added entry to CarInfo in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • test route added to routes.py
  • route with stock system: a74afe0cf708748f|2023-09-02--19-56-27
  • route with openpilot: a74afe0cf708748f|2023-09-10--11-18-49
  • harness Type: Hyundai H
  • architecture: CAN

Link to all physical parts during installation

Requires

Thanks to community 2021 Hyundai Nexo owner SimonYang402.

@sunnyhaibin sunnyhaibin marked this pull request as ready for review September 11, 2023 16:59
…1-port

# Conflicts:
#	opendbc
#	selfdrive/car/torque_data/override.yaml
…1-port

# Conflicts:
#	RELEASES.md
#	panda
#	selfdrive/car/hyundai/interface.py
#	selfdrive/car/hyundai/values.py
#	selfdrive/car/torque_data/override.yaml
…1-port

# Conflicts:
#	docs/CARS.md
#	opendbc
#	panda
#	selfdrive/car/hyundai/carstate.py
#	selfdrive/car/hyundai/interface.py
#	selfdrive/car/hyundai/values.py
#	selfdrive/car/tests/routes.py
#	selfdrive/car/torque_data/override.yaml
@sunnyhaibin
Copy link
Contributor Author

@sshane This port is ready to review.

@sshane sshane added car port car vehicle-specific hyundai labels Oct 21, 2023
selfdrive/car/hyundai/carstate.py Outdated Show resolved Hide resolved
selfdrive/car/hyundai/interface.py Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Dec 3, 2023

This PR has had no activity for 30 days. It will be automatically closed in 7 days if there is no activity.

@github-actions github-actions bot added the stale label Dec 3, 2023
sunnyhaibin and others added 6 commits December 8, 2023 00:35
…1-port

# Conflicts:
#	docs/CARS.md
#	opendbc
#	panda
#	selfdrive/car/hyundai/interface.py
#	selfdrive/car/torque_data/override.yaml
@github-actions github-actions bot removed the stale label Dec 9, 2023
…1-port

# Conflicts:
#	RELEASES.md
#	docs/CARS.md
#	opendbc
#	panda
#	selfdrive/car/hyundai/values.py
@sunnyhaibin
Copy link
Contributor Author

@sshane can we mark this with ignore-stale tag?

@adeebshihadeh
Copy link
Contributor

car port gets ignored by the stale bot now.

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@sshane
Copy link
Contributor

sshane commented Aug 20, 2024

We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.

PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject

Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants