parser_pyx: return empty list if strings is empty #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanlee
force-pushed
the
parser_return_empty_list_if_no_strings
branch
6 times, most recently
from
916d8bb
to
a46b23f
Compare
deanlee
force-pushed
the
parser_return_empty_list_if_no_strings
branch
from
a46b23f
to
47aed66
Compare
deanlee
force-pushed
the
parser_return_empty_list_if_no_strings
branch
from
47aed66
to
51b8628
Compare
|
@adeebshihadeh @sshane this pr is ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve: #913
__init__relies on sending an empty list toupdate_strings() to complete the initialization of hash tables. This makes the code hard to understand and can cause bugs.