-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CANParser: update_strings returns latest state when passed empty list #913
Comments
No it shouldn't return anything. Some confusing interaction with the timing variables in parser.cc is going on. We can choose not to update the Lines 320 to 322 in 7d61776
Also, here we set Line 212 in 7d61776
|
currently, |
CANParser::update_strings
returns most recently updated addresses, when called with an empty list.Is it expected behavior? Shouldn't it return empty list of addresses, since nothing was updated?
Snippet showcasing this behavior:
The text was updated successfully, but these errors were encountered: