Skip to content

Commit

Permalink
Correct html titles for evaluation app (#3630)
Browse files Browse the repository at this point in the history
This is part of Task 2 under issue
#3556 aiming to make
sure the titles are clear and correct.

Each app will have a PR to make sure titles are clear and correct for
all pages that have breadcrumbs as described in issue
#3556
  • Loading branch information
ammar257ammar authored Oct 24, 2024
1 parent d777e2b commit afbe361
Show file tree
Hide file tree
Showing 9 changed files with 21 additions and 23 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{% load url %}

{% block title %}
Delete -{% if object %} {{ object.title|title }} -{% endif %} {{ block.super }}
Delete - {{ object.title|title }} - {{ block.super }}
{% endblock %}

{% block breadcrumbs %}
Expand All @@ -13,11 +13,9 @@
<li class="breadcrumb-item"><a
href="{{ challenge.get_absolute_url }}">{% firstof challenge.title challenge.short_name %}</a></li>
<li class="breadcrumb-item"><a
href="{% url 'evaluation:leaderboard' challenge_short_name=challenge.short_name slug=challenge.phase_set.first.slug %}">Combined Leaderboards</a></li>
{% if object %}
<li class="breadcrumb-item"><a
href="{{ object.get_absolute_url }}">{{ object.title|title }}</a></li>
{% endif %}
href="{% url 'evaluation:leaderboard' challenge_short_name=challenge.short_name slug=challenge.phase_set.first.slug %}">Leaderboards</a></li>
<li class="breadcrumb-item"><a
href="{{ object.get_absolute_url }}">{{ object.title|title }}</a></li>
<li class="breadcrumb-item active"
aria-current="page">Delete</li>
</ol>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{% load crispy_forms_tags %}

{% block title %}
{{ object|yesno:"Update,Create" }} -{% if object %} {{ object.title|title }} -{% endif %} {{ block.super }}
{{ object|yesno:"Update,Create Leaderboard" }} {% if object %} - {{ object.title|title }} {% else %} - Leaderboards {% endif %} - {{ block.super }}
{% endblock %}

{% block breadcrumbs %}
Expand All @@ -16,13 +16,13 @@
<li class="breadcrumb-item"><a
href="{{ challenge.get_absolute_url }}">{% firstof challenge.title challenge.short_name %}</a></li>
<li class="breadcrumb-item"><a
href="{% url 'evaluation:leaderboard' challenge_short_name=challenge.short_name slug=challenge.phase_set.first.slug %}">Combined Leaderboards</a></li>
href="{% url 'evaluation:leaderboard' challenge_short_name=challenge.short_name slug=challenge.phase_set.first.slug %}">Leaderboards</a></li>
{% if object %}
<li class="breadcrumb-item"><a
href="{{ object.get_absolute_url }}">{{ object.title|title }}</a></li>
{% endif %}
<li class="breadcrumb-item active"
aria-current="page">{{ object|yesno:"Update,Create" }}</li>
aria-current="page">{{ object|yesno:"Update,Create Combined Leaderboard" }}</li>
</ol>
{% endblock %}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
{% load url %}

{% block title %}
Configure algorithm phases - {% firstof challenge.title challenge.short_name %} - {{ block.super }}
Configure Algorithm Phases - {% firstof challenge.title challenge.short_name %} - {{ block.super }}
{% endblock %}

{% block breadcrumbs %}
Expand All @@ -14,7 +14,7 @@
<li class="breadcrumb-item"><a
href="{{ challenge.get_absolute_url }}">{% firstof challenge.title challenge.short_name %}</a></li>
<li class="breadcrumb-item active"
aria-current="page">Configure algorithm phases</li>
aria-current="page">Configure Algorithm Phases</li>
</ol>
{% endblock %}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{% load static %}

{% block title %}
Evaluations - {% firstof challenge.title challenge.short_name %} - {{ block.super }}
Evaluations for {{ phase.title }} - {% firstof challenge.title challenge.short_name %} - {{ block.super }}
{% endblock %}

{% block breadcrumbs %}
Expand All @@ -17,7 +17,7 @@
<li class="breadcrumb-item"><a
href="{{ challenge.get_absolute_url }}">{% firstof challenge.title challenge.short_name %}</a></li>
<li class="breadcrumb-item active"
aria-current="page">Evaluations
aria-current="page">Evaluations for {{ phase.title }}
</li>
</ol>
{% endblock %}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
{% load crispy_forms_tags %}

{% block title %}
{{ object.pk }} - Ground truths - {{ block.super }}
{{ object.pk }} - Ground Truths - {{ block.super }}
{% endblock %}

{% block breadcrumbs %}
Expand All @@ -19,7 +19,7 @@
href="{{ challenge.get_absolute_url }}">{% firstof challenge.title challenge.short_name %}</a></li>
<li class="breadcrumb-item">
<a href="{% url 'evaluation:ground-truth-list' challenge_short_name=challenge.short_name slug=object.phase.slug %}">
Ground truths</a>
Ground Truths</a>
</li>
<li class="breadcrumb-item active"
aria-current="page">{{ object.pk }}</li>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
{% load url %}

{% block title %}
{{ object|yesno:"Update,Create" }} -{% if object %} {{ object.pk }} -{% endif %} {{ block.super }}
{{ object|yesno:"Update,Create Ground Truth" }} {% if object %} - {{ object.pk }} {% else %} - Ground Truths {% endif %} - {{ block.super }}
{% endblock %}

{% block breadcrumbs %}
Expand All @@ -22,7 +22,7 @@
</li>
{% endif %}
<li class="breadcrumb-item active"
aria-current="page">{{ object|yesno:"Update,Create" }}</li>
aria-current="page">{{ object|yesno:"Update,Create Ground Truth" }}</li>
</ol>
{% endblock %}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{% load crispy_forms_tags %}

{% block title %}
Ground Truth Version Management - Ground truths - {{ block.super }}
Ground Truth Version Management - Ground Truths - {{ block.super }}
{% endblock %}

{% block breadcrumbs %}
Expand All @@ -15,7 +15,7 @@
href="{{ challenge.get_absolute_url }}">{% firstof challenge.title challenge.short_name %}</a></li>
<li class="breadcrumb-item">
<a href="{% url 'evaluation:ground-truth-list' challenge_short_name=challenge.short_name slug=phase.slug %}">
Ground truths</a>
Ground Truths</a>
</li>
<li class="breadcrumb-item active"
aria-current="page">Ground Truth Version Management</li>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
{% load url %}

{% block title %}
{{ object|yesno:"Update,Create" }} -{% if object %} {{ object.pk }} -{% endif %} {{ block.super }}
{{ object|yesno:"Update,Create Evaluation Method" }} {% if object %} - {{ object.pk }} {% else %} - Evaluation Methods {% endif %} - {{ block.super }}
{% endblock %}

{% block breadcrumbs %}
Expand All @@ -22,7 +22,7 @@
</li>
{% endif %}
<li class="breadcrumb-item active"
aria-current="page">{{ object|yesno:"Update,Create" }}</li>
aria-current="page">{{ object|yesno:"Update,Create Evaluation Method" }}</li>
</ol>
{% endblock %}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{% load static %}

{% block title %}
{% if object %}Update {{ object.title }} Phase{% else %}Add a New Phase{% endif %} -
{{ object|yesno:"Update,Create Phase" }} {% if object %} {{ object.title }} {% endif %} -
{% firstof challenge.title challenge.short_name %} - {{ block.super }}
{% endblock %}

Expand All @@ -16,7 +16,7 @@
<li class="breadcrumb-item"><a
href="{{ challenge.get_absolute_url }}">{% firstof challenge.title challenge.short_name %}</a></li>
<li class="breadcrumb-item active"
aria-current="page">{% if object %}Update {{ object.title }} Phase{% else %}Add a New Phase{% endif %}</li>
aria-current="page">{{ object|yesno:"Update,Create Phase" }} {% if object %} {{ object.title }} {% endif %}</li>
</ol>
{% endblock %}

Expand Down

0 comments on commit afbe361

Please sign in to comment.