Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update protos to recent CometBFT in main, with RFC 106 and skip_extension_signing #17

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update protos to recent CometBFT in main, with RFC 106 and skip_extension_signing #17

wants to merge 5 commits into from

Commits on Mar 4, 2024

  1. Update protos to recent CometBFT in main, with RFC 106 

    Since CometBFT 1.0.0-alpha.1, there was one significant change:
GetLatest* methods were removed from the data companion API
as per RFC 106. Regenerate cometbft-proto from a recent cometbft commit that includes the changes.
    @mzabaluev
    mzabaluev committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    95b9e77 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Update to sign_extension field added in cometbft 

    NOTE: the default is set to true when converting from earlier version.
    @mzabaluev
    mzabaluev committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    da301d5 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. proto: update to skip_extension_signing 

    The cometbft.privval.v1.SignVoteRequest message had the recently added
sign_extension field renamed to skip_extension_signing.
Change the source commit and regenerate the protos.
    @mzabaluev
    mzabaluev committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    e62c99a View commit details
    Browse the repository at this point in the history

  2. cometbft: update SignVoteRequest domain type 

    The sign_extension field was renamed to skip_extension_signing
with flipped value semantics.
    @mzabaluev
    mzabaluev committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    70455f2 View commit details
    Browse the repository at this point in the history

  3. Exercise skip_extension_signing set to true in v1 proto

    @mzabaluev
    mzabaluev committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    dfe7bdf View commit details
    Browse the repository at this point in the history