-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dev-dependency rspec #177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Perhaps we want to add a dependabot config 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, looks like usage needs to be updated. Yet again, I should have let CI run before submitting my review 😅
Let me fix that; my bad for not running it locally |
You can also use a codespace if you'd prefer. |
I'm not very familiar with codespace (haven't used it yet), but a dependabot config sounds like a good idea. Maybe the default setup is good enough? |
Yeah the default config should be good enough. One common practice is to create a "dev dependency" group so they're updated in one PR, if you want to add that. Codespaces are easy to use. It's basically VS Code running in the browser. You can also connect to the VM running on the cloud with a locally running IDE, but VS Code for the Web is the easiest to set up and what GitHub's site will do by default. You definitely don't have to use them to contribute, I'm just letting you know there are other options besides running tests locally. I'd be happy to answer any questions about them -- they're my favorite GH feature. |
While looking at the crate version I noticed this one is finally released (3 years ago), so figured I could bump this too. I kept the same format as the other dev dependencies for consistency.