replace lazy_static with OnceLock #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtlawrence
requested changes
Jan 15, 2024
src/control.rs
Outdated
| /// The persistent [`ShouldColorize`]. | ||
| pub static ref SHOULD_COLORIZE: ShouldColorize = ShouldColorize::from_env(); | ||
| pub fn should_colorize_data() -> &'static ShouldColorize { |
There was a problem hiding this comment.
Maybe rename as should_colorize_global? or get_should_colorize?
kurtlawrence
approved these changes
Jan 17, 2024
kurtlawrence
requested changes
Jan 17, 2024
kurtlawrence
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #163
This is technically a breaking change because
SHOULD_COLORIZEused to be public a static var, and now it's a function.If this is not acceptable, the other variant would be to use the
once_cellcrate which provides Lazy which is more similar to howlazy_staticwas working. This API is unstable in std at the moment.