Handle possible errors in set_virtual_terminal
#105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mackwic
reviewed
Jul 2, 2023
hwittenborn
force-pushed
the
master
branch
3 times, most recently
from
744b5dd
to
1921f20
Compare
kurtlawrence
approved these changes
Dec 10, 2023
kurtlawrence
added
the
needs-changelog
|
Conflicts need resolving |
madsmtm
force-pushed
the
windows-handle-errors
branch
from
81bf1c5
to
bf9f7b6
Compare
kurtlawrence
added a commit
that referenced
this pull request
Dec 12, 2023
This reverts commit a9aa7d8.
kurtlawrence
added a commit
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_virtual_terminalwas changed in #68 to never return an error - this is probably incorrect, as the underlying Win32 functions can definitely return errors.Error handling grabbed from borntyping/rust-simple_logger#11