-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bobtemplates.plone to create Plone addon structure #25
base: main
Are you sure you want to change the base?
Conversation
@erral, thanks for this PR.
|
regarding the 2nd one, I would modify the actual bobtemplate.plone addon template to remove the namespace requirement and for the sane defaults, perhaps add there in bobtemplates.plone a subtemplate providing them |
Thanks! When the release is ready, I will work on using it in this package, and I will also try to work on a subtemplate following Erico's suggestion |
01d2a4c
to
c2a94dd
Compare
See plone/bobtemplates.plone#526 for the starter template. Right now this package only sets 2 values in the default Plone site it creates: the site title and the default language. All other things that are created in the generated plone addon package are just empty folders for behaviors, serializers, services, content types, etc. which are already handled by bobtemplates.plone so can be ditched. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First: thanks a lot!
Some changes before I would merge from my POV:
- use
plonecli
and avoid usingmr.bob
directly. We want people to work with plonecli (and improve plonecli for Plone 6). - use
pipx run plonecli create addon
instead of addingbobtemplates.plone
to therequirements.txt
. - add
pipx
as the only new torequirements.txt
(plan is to use pipx for other tools like isort/black/... in future, so it is good there for now.
right now it looks like it is not possible to pass the --config parameter that mr.bob uses to provide default answers in a non-interactive way to plonecli 😕 I'll keep looking at it. |
LGTM now. If the other parts are merged and released (plonecli/bobtemplates.plone) this one can be merged too from my POV. |
Whats the state here? |
I would suggest we sprint on plonecli during Alpine sprint, then merge this |
There is indeed a PR on plonecli to add a Plone site initializer subtemplate. But it just adds 2 settings site title and languages, and may be it is a bit poor subtemplate to add it to bobtemplates.plone, don't know... We can neglect that, or improve it if more settings can be added to a site initializer... But I don't see what more can be added there... |
I'll be there too, happy to help ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Wait for plone/bobtemplates.plone#526 to be merged before this. |
I have rebased on top of the changes last months... I will need a release for bobtemplates.plone to test this properly. |
A bobtemplates.plone release sounds like a task for @MrTango ;-) |
@erral bobtemplates.plone is released in version 6.3.2 now, please test ;) |
Fixes #20
I had to do the following:
Use {{python_package_name}}.addon as the addon name, because bobtemplates.plone requires to use namespaced package names. If this changes in the future, we can change it here too @MrTango