Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dryd 1511 dupe id report bug #222

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Dryd 1511 dupe id report bug #222

wants to merge 8 commits into from

Commits on Sep 3, 2024

  1. Rubocop safe autocorrects

    @kspurgin
    kspurgin committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    40e13ba View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Refactor ProcessJob and RecordUniquenessService 

    This avoids confusing the step with other meanings of "process" in
this job (e.g. process the data, process the report)
    @kspurgin
    kspurgin committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f203ddb View commit details
    Browse the repository at this point in the history

  2. Handle new format of duplicate id warning

    @kspurgin
    kspurgin committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    ca9b643 View commit details
    Browse the repository at this point in the history

  3. Update expected value due to adding a row to test CSV

    @kspurgin
    kspurgin committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f232a2f View commit details
    Browse the repository at this point in the history

  4. Only write unique missing terms report if there are missing terms 

    I.e. do not write provisional stub report with headers to add to for
every batch.
    @kspurgin
    kspurgin committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    e55de12 View commit details
    Browse the repository at this point in the history

  5. Handle both Hash and String messages

    @kspurgin
    kspurgin committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    5dea25a View commit details
    Browse the repository at this point in the history

  6. Fix method names. 

    StepManagerService has the new method names for 3 years so I have NO
CLUE how thi hasn't blown up repeatedly.
    @kspurgin
    kspurgin committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    53e6617 View commit details
    Browse the repository at this point in the history

  7. Extract processing report finalization to its own testable class

    @kspurgin
    kspurgin committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    747f8ae View commit details
    Browse the repository at this point in the history