Added new units and aliases - updated units.json #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New units added - Mbpd and cf/bbl new alias added for cubic foot, cubic foot per day and kilo ft3
|
Hi Team, Can you please help me why the build failed? Thanks, |
polomani
reviewed
Oct 17, 2024
Co-authored-by: Ivan Polomani <[email protected]>
polomani
reviewed
Oct 17, 2024
versions/v1/units.json
Outdated
Comment on lines
10607
to
10617
| "aliasNames": [ | ||
| "kilo barrels per day", | ||
| "thousand barrels per day", | ||
| "kbpd", | ||
| "kb/d", | ||
| "Mb/d", | ||
| "MBPD", | ||
| "Mbpd", | ||
| "Mbbl/d", | ||
| "kBbl/day" | ||
| ], |
There was a problem hiding this comment.
need to run a formatter, here and similar situation below
There was a problem hiding this comment.
@polomani ran the entire json in a json formatter. Please verify
There was a problem hiding this comment.
this is too much, can you make sure the format you use only formats the fields you changed?
if not, please format manually what you changed, so we can keep proper git history.
There was a problem hiding this comment.
let me raise a new PR for this. I will close this PR from my end
Formatted json as per PR 115 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New units added - Mbpd and cf/bbl
new alias added for cubic foot, cubic foot per day and kilo ft3