Runtime 15 e2e #1043
Runtime 15 e2e #1043
Conversation
|
Skipping CI for Draft Pull Request. |
| @@ -440,9 +440,10 @@ func (a *Awaitility) CreateNamespace(t *testing.T, name string) { | |||
| func (a *Awaitility) WaitForDeploymentToGetReady(t *testing.T, name string, replicas int, criteria ...DeploymentCriteria) *appsv1.Deployment { | |||
| t.Logf("waiting until deployment '%s' in namespace '%s' is ready", name, a.Namespace) | |||
| deployment := &appsv1.Deployment{} | |||
| err := wait.Poll(a.RetryInterval, 6*a.Timeout, func() (done bool, err error) { | |||
| err := wait.PollUntilContextTimeout(context.TODO(), a.RetryInterval, 6*a.Timeout, true, func(ctx context.Context) (done bool, err error) { | |||
There was a problem hiding this comment.
Poll is deprecated
ranakan19
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
sbryzak and
mfrancisc
as code owners
…Get, revert retryInterval
| @@ -365,11 +364,12 @@ func TestProxyFlow(t *testing.T) { | |||
| require.NoError(t, err) | |||
| err = proxyCl.Create(context.TODO(), appToCreate) | |||
|
|
|||
| // then | |||
There was a problem hiding this comment.
This comment block is removed as it is no longer valid. Maintaining history here might be confusing
… into runtime_15_e2e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, ranakan19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Alexey Kazakov <[email protected]>
|
|
Changes this PR includes:
- With the changes to rest mapper that provided client for discovery information to do REST mappings, breaks the use case of checking available APIs via
k8s.io/apimachinery/pkg/api/errors.IsNotFoundandk8s.io/apimachinery/pkg/api/meta.IsNoMatchError. This means can not directly check for those errors, but should expect server error. This only affected proxy tests and the tests now check for error contains. Can find more details in this issue- Tried to propogate the context from PollUntillContextTimeout to the api calls within the condition function but it fails with
would exceed context deadlineas the last error instead of the expectedcontext deadline exceedederror. Please refer this comment for more details. And other PR which use the same solution of intentionally pass a separate context to api calls in the consition function.- PollUntillContextTimeout will no longer return
ErrWaitTimeout- So replaces errTimeout checks with context deadline checks. [refer this PR for more information if needed]