-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KUBESAW-100: Refactoring toolchaincluster controller-Pair Host operator #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Feny Mehta <[email protected]>
fbm3307
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
July 5, 2024 09:57
rsoaresd
reviewed
Jul 8, 2024
Signed-off-by: Feny Mehta <[email protected]>
fbm3307
changed the title
KUBESAW-100: Refactoring toolchaincluster controller
KUBESAW-100: Refactoring toolchaincluster controller-Pair Host operator
Jul 9, 2024
This was referenced Jul 9, 2024
Merged
Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
MatousJobanek
approved these changes
Jul 12, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbm3307, MatousJobanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Feny Mehta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is updating the e2e test case and is paired with host operator PR -
Host-opertor - codeready-toolchain/host-operator#1049
Related PR
Toolchain-Common - codeready-toolchain/toolchain-common#401
Related PR where only change is updating the dependency
Member-operator - codeready-toolchain/member-operator#579
Registration-Service - codeready-toolchain/registration-service#437
Sandbox-SRE - https://github.com/codeready-toolchain/sandbox-sre/pull/1830
KSCTL - kubesaw/ksctl#42