Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some linter's complaints #384

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

filariow
Copy link
Contributor

@filariow filariow commented Apr 4, 2024

Signed-off-by: Francesco Ilario [email protected]

Signed-off-by: Francesco Ilario <[email protected]>
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Merging #384 (207c3e3) into master (6b578e1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
+ Coverage   75.73%   75.75%   +0.01%     
==========================================
  Files          45       45              
  Lines        1727     1728       +1     
==========================================
+ Hits         1308     1309       +1     
  Misses        367      367              
  Partials       52       52              
Files Coverage Δ
pkg/cluster/service.go 83.59% <100.00%> (+0.12%) ⬆️
pkg/template/processor.go 84.00% <ø> (ø)

@filariow filariow changed the title fixing some linters complaints fix some linter's complaints Apr 4, 2024
Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for looking at those linting issues and making those improvements 🙏

I have one small comment.

pkg/cluster/service.go Outdated Show resolved Hide resolved
Signed-off-by: Francesco Ilario <[email protected]>
Copy link

sonarcloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
4.1% Duplication on New Code

See analysis details on SonarCloud

@alexeykazakov alexeykazakov merged commit fd379c9 into codeready-toolchain:master Apr 8, 2024
8 checks passed
@filariow filariow deleted the linting branch April 9, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants