Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop CRTClient abstraction #473

Merged

Merge branch 'master' into drop-crtclient

cff0b63
Select commit
Loading
Failed to load commit list.
Merged

drop CRTClient abstraction #473

Merge branch 'master' into drop-crtclient
cff0b63
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 3, 2024 in 0s

85.43% (+2.96%) compared to d0b1f7d

View this Pull Request on Codecov

85.43% (+2.96%) compared to d0b1f7d

Details

Codecov Report

Attention: Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.43%. Comparing base (d0b1f7d) to head (cff0b63).

Files with missing lines Patch % Lines
pkg/signup/service/signup_service.go 80.00% 1 Missing and 4 partials ⚠️
pkg/server/in_cluster_application.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
+ Coverage   82.47%   85.43%   +2.96%     
==========================================
  Files          42       33       -9     
  Lines        2687     2541     -146     
==========================================
- Hits         2216     2171      -45     
+ Misses        385      283     -102     
- Partials       86       87       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.