fix: log errors inside VerifyPhoneCode

[mfrancisc]

This PR moves all the logging inside the VerifyPhoneCode function and removes the log error from the caller since the function might return an error that doesn't need to be logged which was already logged as Info.

[alexeykazakov]

Thanks!

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.83%. Comparing base (bc6b76d) to head (788d1c9).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/verification/service/verification_service.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
- Coverage   81.89%   81.83%   -0.07%     
==========================================
  Files          42       42              
  Lines        2707     2708       +1     
==========================================
- Hits         2217     2216       -1     
- Misses        404      406       +2     
  Partials       86       86              

Flag	Coverage Δ
unittests	81.83% <0.00%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MatousJobanek]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, mfrancisc, rajivnathan, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,alexeykazakov,mfrancisc,rajivnathan,xcoulon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment