Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest toolchain-common #458

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

metlos
Copy link
Contributor

@metlos metlos commented Sep 9, 2024

Update to the latest toolchain-common so that connections to clusters are loaded from the kubeconfig in TC secrets.

… are

loaded from the kubeconfig in TC secrets.
Copy link

sonarcloud bot commented Sep 9, 2024

@openshift-ci openshift-ci bot added the approved label Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.73%. Comparing base (811f9b3) to head (9dd276a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   78.73%   78.73%           
=======================================
  Files          42       42           
  Lines        2742     2742           
=======================================
  Hits         2159     2159           
  Misses        490      490           
  Partials       93       93           
Flag Coverage Δ
unittests 78.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, metlos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metlos metlos merged commit 22b13b9 into codeready-toolchain:master Sep 9, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants