Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Public-Viewer support #443

Merged
merged 87 commits into from
Sep 26, 2024
Merged

feat: add Public-Viewer support #443

merged 87 commits into from
Sep 26, 2024

Commits on Jul 12, 2024

  1. fix: use UTC time in tests 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    1cfcd94 View commit details
    Browse the repository at this point in the history

  2. add public-viewer support 

    This commit adds the notion of Public-Viewer to the Proxy as described
in [JIRA ASC-532](https://issues.redhat.com/browse/ASC-532).

Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    2c897f6 View commit details
    Browse the repository at this point in the history

  3. enable public-viewer support in spacelister_get 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    52156fe View commit details
    Browse the repository at this point in the history

  4. add unit tests for pkg/configuration 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    573aecc View commit details
    Browse the repository at this point in the history

  5. add tests for log 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    fc99e4e View commit details
    Browse the repository at this point in the history

  6. add unit tests for proxy 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    962c87c View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Alexey Kazakov <[email protected]>
    @filariow @alexeykazakov
    filariow and alexeykazakov authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    ec8b470 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into pv-532

    @filariow
    filariow authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    8193b55 View commit details
    Browse the repository at this point in the history

  3. fix linter 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    91ff1aa View commit details
    Browse the repository at this point in the history

  4. return empty slice instead of nil 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    6c2a595 View commit details
    Browse the repository at this point in the history

  5. simplify getUserSpaceBinding 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    ca4b882 View commit details
    Browse the repository at this point in the history

  6. cleanup tests 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    7f015b5 View commit details
    Browse the repository at this point in the history

  7. refactor spacelister_get tests 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    941e052 View commit details
    Browse the repository at this point in the history

  8. refactor 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    4981f91 View commit details
    Browse the repository at this point in the history

  9. fix spacelister list 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    76e43eb View commit details
    Browse the repository at this point in the history

  10. enhance spacelister get tests 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    a85b104 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Merge remote-tracking branch 'upstream/master' into pv-532

    @filariow
    filariow committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    75fec5c View commit details
    Browse the repository at this point in the history

  2. remove unreachable check 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    0d3bfc5 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Merge branch 'master' into pv-532

    @filariow
    filariow authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    6941c15 View commit details
    Browse the repository at this point in the history

  2. add tests for cluster-service 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    9136bb0 View commit details
    Browse the repository at this point in the history

  3. add user validation test 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    7ec2cb4 View commit details
    Browse the repository at this point in the history

  4. add tests for validateSpace 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    f362ac5 View commit details
    Browse the repository at this point in the history

  5. use ptr 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    3b7d1c2 View commit details
    Browse the repository at this point in the history

  6. add test case for non-ready user 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    650a6a2 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Merge remote-tracking branch 'upstream/master' into pv-532

    @filariow
    filariow committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e275514 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. fix configuration tests comments 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    4e51460 View commit details
    Browse the repository at this point in the history

  2. Update pkg/proxy/handlers/spacelister_get.go 

    Co-authored-by: Francisc Munteanu <[email protected]>
    @filariow @mfrancisc
    filariow and mfrancisc authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    dfa1533 View commit details
    Browse the repository at this point in the history

  3. refactor proxy.go 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    69be0bf View commit details
    Browse the repository at this point in the history

  4. refactor comments and function names 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    ef8e333 View commit details
    Browse the repository at this point in the history

  5. refactor 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    8cf0f7b View commit details
    Browse the repository at this point in the history

  6. fix comments 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    29dd7fe View commit details
    Browse the repository at this point in the history

  7. improve code readability 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    00dd2f4 View commit details
    Browse the repository at this point in the history

  8. improve cluster_service code reuse 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    f9b9b5a View commit details
    Browse the repository at this point in the history

  9. Add pkg/context tests for public-viewer 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    c683c65 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Merge remote-tracking branch 'upstream/master' into pv-532

    @filariow
    filariow committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    f533353 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into pv-532

    @filariow
    filariow committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    08cb567 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Merge remote-tracking branch 'upstream/master' into pv-532

    @filariow
    filariow committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    43f6c58 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. improve tests 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    3452b2b View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Merge remote-tracking branch 'upstream/master' into pv-532

    @filariow
    filariow committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    ac24de1 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Merge remote-tracking branch 'upstream/master' into pv-532

    @filariow
    filariow committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    4d863bb View commit details
    Browse the repository at this point in the history

  2. rollback changes to pkg/server/in_cluster_application.go 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    2b62f6c View commit details
    Browse the repository at this point in the history

  3. add PublicViewer's middleware 

    this commit is part of the effort of splitting codeready-toolchain#443

Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    3ccbee7 View commit details
    Browse the repository at this point in the history

  4. remove ctx set in favor of middleware 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    276323b View commit details
    Browse the repository at this point in the history

  5. fix error message 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    8d944fb View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Update pkg/proxy/proxy.go 

    Co-authored-by: Alexey Kazakov <[email protected]>
    @filariow @alexeykazakov
    filariow and alexeykazakov authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    f74ee96 View commit details
    Browse the repository at this point in the history

  2. remove not needed checks 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    d278ea7 View commit details
    Browse the repository at this point in the history

  3. remove unused parameter 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    6f97b34 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Update pkg/proxy/proxy.go 

    Co-authored-by: Alexey Kazakov <[email protected]>
    @filariow @alexeykazakov
    filariow and alexeykazakov authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    7934119 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. fix tests 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    30b980b View commit details
    Browse the repository at this point in the history

  2. improve comments 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    51fe1a4 View commit details
    Browse the repository at this point in the history

  3. remove redundant check 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    e27d558 View commit details
    Browse the repository at this point in the history

  4. improve returned error and logging 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    96b1646 View commit details
    Browse the repository at this point in the history

  5. improve comments 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    048f29b View commit details
    Browse the repository at this point in the history

  6. improve comments 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    d9299c5 View commit details
    Browse the repository at this point in the history

  7. check if public-viewer has access to space before forwarding 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    6408242 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into pv-532

    @filariow
    filariow authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    76ca225 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. add test for not signed up user 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a2bc3f8 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into pv-532

    @filariow
    filariow committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    1995b76 View commit details
    Browse the repository at this point in the history

  3. fix typo in comment 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    47ab59e View commit details
    Browse the repository at this point in the history

  4. refactor user names and cleanup test 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d4fee9b View commit details
    Browse the repository at this point in the history

  5. rename notReadyUser to john 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e614e38 View commit details
    Browse the repository at this point in the history

  6. rename notSignedUpUser to bob 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    bd91b58 View commit details
    Browse the repository at this point in the history

  7. remove communityuser in favor of alice 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    241fd5a View commit details
    Browse the repository at this point in the history

  8. fix linter complaints 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    139809a View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'upstream/master' into pv-532

    @filariow
    filariow committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a2a9837 View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'upstream/master' into pv-532

    @filariow
    filariow committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b1e93fb View commit details
    Browse the repository at this point in the history

  11. Add tests for banneduser in community tests 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    ea515a6 View commit details
    Browse the repository at this point in the history

  12. use ElementsMatch instead of Equal to reduce flakyness 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    3db6128 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. remove unnecessary TODO comment 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b18db56 View commit details
    Browse the repository at this point in the history

  2. refactor tests 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d5c1503 View commit details
    Browse the repository at this point in the history

  3. refactor tests 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    94e45a0 View commit details
    Browse the repository at this point in the history

  4. revert unneeded changes to test/fake/proxy.go 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    306b6d6 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Merge remote-tracking branch 'upstream/master' into pv-532

    @filariow
    filariow committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    fd3e191 View commit details
    Browse the repository at this point in the history

  2. check proxy has forwarded the call 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    13d335a View commit details
    Browse the repository at this point in the history

  3. add comments and fix typos 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    15fa0cd View commit details
    Browse the repository at this point in the history

  4. add more test cases 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    83ea573 View commit details
    Browse the repository at this point in the history

  5. remove dead code 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5d0f604 View commit details
    Browse the repository at this point in the history

  6. consolidate code 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c071225 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/master' into pv-532

    @filariow
    filariow committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    a3eff03 View commit details
    Browse the repository at this point in the history

  8. fix linter complaints 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    e09cd75 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Merge branch 'master' into pv-532

    @filariow
    filariow authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    cf79085 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. add comment 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    599e2d2 View commit details
    Browse the repository at this point in the history

  2. check proxy requires email in the JWT token 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    150dbd0 View commit details
    Browse the repository at this point in the history

  3. remove publicViewer leftovers from test 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c343167 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into pv-532

    @filariow
    filariow committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    087b0dc View commit details
    Browse the repository at this point in the history

  5. sort proxy middlewares 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8ba3452 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. remove unneeded comment 

    Signed-off-by: Francesco Ilario <[email protected]>
    @filariow
    filariow committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    0ffff03 View commit details
    Browse the repository at this point in the history