read target cluster from Space #441
Conversation
MatousJobanek
requested review from
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #441 +/- ##
==========================================
+ Coverage 78.54% 78.57% +0.03%
==========================================
Files 38 38
Lines 2601 2600 -1
==========================================
Hits 2043 2043
Misses 462 462
+ Partials 96 95 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| continue | ||
| } | ||
| space, err := provider.GetSpace(spaceName) | ||
| func GetDefaultUserTarget(provider ResourceProvider, spaceName, murName string) (string, string) { |
There was a problem hiding this comment.
Can you add a comment to the function stating that it returns <target-member-cluster>, <default-namespace>?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, MatousJobanek, mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
MatousJobanek
merged commit 3002baf
into
codeready-toolchain:master
KUBESAW-107
KUBESAW-108
Take the target cluster from Space (either the home one or the first Space the user has access to)
changes in go.sum are result of running
go mod tidy