rename client to restClient

[MatousJobanek]

a small change to make it ready for introduction of the controller-runtime client. I'm just trying to minimize the amount of changes, but I'm afraid that it's gonna be a huge change/PR anyway

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 78.54%. Comparing base (2b19d34) to head (c988270).

Files	Patch %	Lines
pkg/kubeclient/client.go	59.45%	15 Missing ⚠️
pkg/kubeclient/signup.go	0.00%	3 Missing ⚠️
pkg/kubeclient/mur.go	0.00%	1 Missing ⚠️
pkg/kubeclient/socialevent.go	0.00%	1 Missing ⚠️
pkg/kubeclient/space.go	0.00%	1 Missing ⚠️
pkg/kubeclient/toolchainstatus.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #439   +/-   ##
=======================================
  Coverage   78.54%   78.54%           
=======================================
  Files          38       38           
  Lines        2601     2601           
=======================================
  Hits         2043     2043           
  Misses        462      462           
  Partials       96       96           

Flag	Coverage Δ
unittests	78.54% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mfrancisc]

Looks good 👍

Just curious - what is the context for the controller-runtime introduction we are preparing for ?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MatousJobanek, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[MatousJobanek]

Just curious - what is the context for the controller-runtime introduction we are preparing for ?

1. drop our own implementation of the shared informers and use the generic ones from controller-runtime library
2. replace our own wrapper of the RESTClient by the controller-runtime one
3. as a result of the previous cases, drop extra levels of abstraction
4. improve readability of the code
5. simplify it
6. improve unit-test coverage