Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

directly create SA if does not already exist #469

Merged
merged 4 commits into from
Aug 3, 2023
Merged

directly create SA if does not already exist #469

merged 4 commits into from
Aug 3, 2023

Conversation

MatousJobanek
Copy link
Contributor

@MatousJobanek MatousJobanek commented Aug 3, 2023 •
edited
Loading

@openshift-ci openshift-ci bot added the approved label Aug 3, 2023
@mfrancisc mfrancisc mentioned this pull request Aug 3, 2023
Closed
mfrancisc
mfrancisc approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 . Thanks a lot 🙏

@openshift-ci
Copy link

openshift-ci bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MatousJobanek, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
12.3% 12.3% Duplication

@MatousJobanek MatousJobanek mentioned this pull request Aug 3, 2023
Merged
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #469 (48d28e7) into master (ec3ef61) will decrease coverage by 0.06%.
The diff coverage is 78.57%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
- Coverage   82.36%   82.31%   -0.06%     
==========================================
  Files          29       29              
  Lines        3386     3393       +7     
==========================================
+ Hits         2789     2793       +4     
- Misses        453      455       +2     
- Partials      144      145       +1
Files Changed Coverage Δ
controllers/nstemplateset/client.go 81.25% <78.57%> (-4.12%) ⬇️

@MatousJobanek MatousJobanek merged commit 3eb0367 into codeready-toolchain:master Aug 3, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfrancisc mfrancisc mfrancisc approved these changes

@alexeykazakov alexeykazakov Awaiting requested review from alexeykazakov alexeykazakov is a code owner

@xcoulon xcoulon Awaiting requested review from xcoulon xcoulon is a code owner

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatousJobanek @mfrancisc