Introduce ConsumedCapacity into the SpaceProvisionerConfig status

[metlos]

Description

Introduce ConsumedCapacity into the SpaceProvisionerConfig status that is meant to mirror the relevant information from the ToolchainStatus for easier inspection of the cluster conditions.

Checks

1. Did you run make generate target? yes

2. Did make generate change anything in other projects (host-operator, member-operator)? yes

3. In case of new CRD, did you the following? NA

4. In case other projects are changed, please provides PR links.

   • host-operator: Update the CRDs with the ConsumedCapacity in the SpaceProvisionerConfig status. host-operator#1104

[mfrancisc]

I might be wrong but it should require also these markers

Suggested change

	// MemoryUsagePercentPerNodeRole is the percent of the memory used per node role (eg. worker, master)
	MemoryUsagePercentPerNodeRole map[string]int `json:"memoryUsagePercentPerNode"`
	// MemoryUsagePercentPerNodeRole is the percent of the memory used per node role (eg. worker, master)
	// +optional
	// +mapType=atomic
	MemoryUsagePercentPerNodeRole map[string]int `json:"memoryUsagePercentPerNode,omitempty"`

[metlos]

I will add the +maptype=atomic, thanks for pointing it out. As for optional and omitempty, I don't these should be added in this case, see my reply to your comment on the SpaceCount. That said, I also noticed the discrepancy between the field name in go and json, so I'll fix that, too :)

[mfrancisc]

same here - I usually saw that if the parent struct is optional also the fields inside are optional

Suggested change

	// SpaceCount is the number of spaces currently deployed to the cluster
	SpaceCount int `json:"spaceCount"`
	// SpaceCount is the number of spaces currently deployed to the cluster
	// +optional
	SpaceCount int `json:"spaceCount,omitempty"`

[metlos]

The reason for this is that we either have a complete capacity report or none at all. Optional and omitempty only influence the JSON that is marshalled or presented to the user and since this is a status and users are not supposed to edit it, I wouldn't find it useful to provide partial capacity reports or as a user to not see "spaceCount: 0" in the status.

[mfrancisc]

Ok so we will always have both fields SpaceCount and MemoryUsagePercentPerNodeRole populated? There cannot be a situation or timeframe when only one is present ?

[metlos]

nope, we will assign the consumed capacity as a whole, not the individual fields.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud