feat(git-clone): add git@ URLs support #308
Conversation
Add Github and Gitlab when using git@ URLs.
|
Hi @djarbz, do you plan to come back to this? I see we have linting issues. |
Expect [email protected]: to return provider of github
Bump version numbers
|
@matifali thanks for the reminder. |
matifali
changed the title
|
@michaelbrewer Could you review, too, as you are the original author for this functionality? Thanks. |
There was a problem hiding this comment.
Changes look straightforward, but I had a Terraform noob question. I would definitely trust any review from @michaelbrewer above my own, though
| @@ -72,7 +72,7 @@ describe("git-clone", async () => { | |||
| url, | |||
| }); | |||
| expect(state.outputs.repo_dir.value).toEqual("/tmp/coder"); | |||
| expect(state.outputs.git_provider.value).toEqual(""); | |||
| expect(state.outputs.git_provider.value).toEqual("github"); | |||
There was a problem hiding this comment.
Could you explain what changed in the Terraform code that requires the test update?
I'm guessing what was happening before was:
git_providers(plural) map gets defined with the"https://github.com/"and"https://gitlab.com/"keysgit_provider(singular) tried to access a value from the map. There was no match, so the output became an empty string for a zero value- Adding new keys for this PR now makes it so that the output does access a value from the map
That's just a guess, though. I'm still not clear on how defining git_provider as local.provider would allow it to access the map in the first place
There was a problem hiding this comment.
This particular test provided a git@github URL for the repo, but the module originally wasn't configured to match these types of URLs so the output would be a blank string as it did not match.
My PR matches on these types of URLs and so will now output the provider properly as GitHub or Gitlab.
Add Github and Gitlab when using git@ URLs.