feat: add enterprise-desktop image #285
Conversation
Introduce a new desktop image wrapping the base image with XFCE, intended to serve as a base for templates using KasmVNC.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| echo 'export XDG_CURRENT_DESKTOP=xfce' >> /home/$USER/.xsessionrc; \ | ||
| echo 'export XDG_SESSION_TYPE=x11' >> /home/$USER/.xsessionrc; | ||
|
|
||
| USER coder |
There was a problem hiding this comment.
Think this just might be an issue on my end, but running the format checker against the Dockerfile I get this:
$ dprint check --plugins https://plugins.dprint.dev/dockerfile-0.3.0.wasm https://plugins.dprint.dev/markdown-0.17.0.wasm
from /Users/****/Desktop/Projects/test-templates/enterprise-desktop/ubuntu.Dockerfile:
13 13| ····echo·'export·XDG_CURRENT_DESKTOP=xfce'·>>·/home/$USER/.xsessionrc;·\
14 14| ····echo·'export·XDG_SESSION_TYPE=x11'·>>·/home/$USER/.xsessionrc;
15 15|
16|-USER·coder␃
16 |+USER·coder
--Shows an error with there being no newline at the end of USER coder. Adding a newline fixes it, but never ran into this when reintroducing the golang, node, and java images.
If you do see this error though during the build job, this might be the solution just in case. Everything looks good though!
Introduce a new desktop image wrapping the base image with XFCE,
intended to serve as a base for templates using KasmVNC module.
Closes #284