-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for checkout exception #733
base: 3.x
Are you sure you want to change the base?
Add support for checkout exception #733
Conversation
Change-Id: Ib41bc35dd6395656f9d7a9cccf0886e809e8dc5f Signed-off-by: i053322 <[email protected]>
@vinokurig - added the PR from che 4.x |
Please change imports of |
@vinokurig - what did you mean? I moved it and did refactor for all the classes .Do I need to do clone to another repository ? |
You refactored |
@vinokurig - I found this repository https://github.com/codenvy/che-plugins for che-plugins |
sorry, plugins is a private repository |
Ok for me |
@vinokurig - I did it forche-plugins codenvy-legacy/che-plugins#631 is it ok ? |
Looks like you opened a pull request for master but you should open it for 3.x |
@vinokurig -I did it for 3.x |
@vinokurig - this is the last commit in the branch
|
@vinokurig |
ok |
ok @tareqhs it's up to you to merge this pr |
What does this PR do?
The PR add new functionality for the checkout got API. new you can raise the relevant error and not GitAPIException. meaning that you can get the relevant error code and not only 500 and also move the parameters the relevant to the error.
Also there is no mapper for the git messages.
What issues does this PR fix or reference?
In checkout scenario in git you get the relevant error of conflict 409 and not 500. also you get the conflictPath of the error.
Previous Behavior
If there was an error you always get GitAPIException and not the relevant error.
New Behavior
Remove this section if not relevant
For each error in checkout API we will raise the relevant error with the relevant parameters for each error.
Tests written?
No for specific exception scenario.
Docs requirements?
Include the content for all the docs changes required.
Please review Che's Contributing Guide for best practices.
Change-Id: Ib41bc35dd6395656f9d7a9cccf0886e809e8dc5f
Signed-off-by: i053322 [email protected]