Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add more readonly property definitions on AutoRouteCollector and SiteURI #9210

Merged
merged 1 commit into from
Oct 3, 2024
Merged

refactor: add more readonly property definitions on AutoRouteCollector and SiteURI #9210

merged 1 commit into from
Oct 3, 2024

Conversation

samsonasik
Copy link
Member

Description

With manually run latest rector dev-main for feature

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member Author

Ready to merge 👍 , phpstan notice is unrelated.

@kenjis kenjis added the refactor Pull requests that refactor code label Oct 3, 2024
@samsonasik
Copy link
Member Author

Thank you @kenjis for the review, let's merge 👍

@samsonasik samsonasik merged commit 6d3de6d into codeigniter4:develop Oct 3, 2024
40 of 41 checks passed
@samsonasik samsonasik deleted the refactor-more-readonly branch October 3, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner Awaiting requested review from MGatner

@paulbalandan paulbalandan Awaiting requested review from paulbalandan

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @kenjis