Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiple hostname routing #9150

Merged
merged 9 commits into from
Aug 30, 2024

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Aug 26, 2024

Description
Supersedes #9031

Example

$routes->group('api', ['hostname' =>  ['api.website.com', 'api.website.net]], function ($routes) {
    $routes->get('/', 'Api::royplayer');
});

Thanks to @mrjk990

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added enhancement PRs that improve existing functionalities docs needed Pull requests needing documentation write-ups and/or revisions. 4.6 labels Aug 26, 2024
@ddevsr ddevsr removed the docs needed Pull requests needing documentation write-ups and/or revisions. label Aug 27, 2024
@ddevsr ddevsr requested a review from kenjis August 27, 2024 02:28
@ddevsr ddevsr requested a review from kenjis August 27, 2024 03:12
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@kenjis kenjis merged commit b45f151 into codeigniter4:4.6 Aug 30, 2024
42 checks passed
@ddevsr ddevsr deleted the router-multiple-hostname branch August 30, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.6 enhancement PRs that improve existing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants