Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove dependency on BaseConnection in TableName #9104

Merged
merged 1 commit into from
Aug 8, 2024
Merged

refactor: remove dependency on BaseConnection in TableName #9104

merged 1 commit into from
Aug 8, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 5, 2024 •
edited
Loading

Description
Follow-up #8748

TableName should not depend on DB Connection.
Because it may be a table name in another database. See #9085

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the 4.6 label Aug 5, 2024
@kenjis kenjis marked this pull request as draft August 5, 2024 00:37
@kenjis kenjis added the database Issues or pull requests that affect the database layer label Aug 5, 2024
@kenjis
refactor: change 1st param type
640de45 
Remove dependency on BaseConnection.
@kenjis kenjis added the refactor Pull requests that refactor code label Aug 5, 2024
@kenjis kenjis marked this pull request as ready for review August 5, 2024 01:34
@kenjis kenjis changed the title refactor: TableName class refactor: remove dependency on BaseConnection in TableName Aug 5, 2024
@kenjis kenjis merged commit e83b3bd into codeigniter4:4.6 Aug 8, 2024
41 checks passed
@kenjis kenjis deleted the refactor-TableName branch August 8, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@ddevsr ddevsr ddevsr approved these changes

Assignees
No one assigned
Labels
4.6 database Issues or pull requests that affect the database layer refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @ddevsr