Merge pull request #8003 from kenjis/fix-Config-Kint

fix: error on `Config\Kint` with Config Caching
codeigniter4 · Oct 11, 2023 · a8f589d · a8f589d
2 parents b6684e6 + ff2c6b6
commit a8f589d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/app/Config/Kint.php b/app/Config/Kint.php
@@ -2,7 +2,6 @@
 
 namespace Config;
 
-use CodeIgniter\Config\BaseConfig;
 use Kint\Parser\ConstructablePluginInterface;
 use Kint\Renderer\AbstractRenderer;
 use Kint\Renderer\Rich\TabPluginInterface;
@@ -18,7 +17,7 @@
  *
  * @see https://kint-php.github.io/kint/ for details on these settings.
  */
-class Kint extends BaseConfig
+class Kint
 {
  /*
  |--------------------------------------------------------------------------

diff --git a/system/CodeIgniter.php b/system/CodeIgniter.php
@@ -296,7 +296,7 @@ private function autoloadKint(): void
 
  private function configureKint(): void
  {
- $config = config(KintConfig::class);
+ $config = new KintConfig();
 
  Kint::$depth_limit = $config->maxDepth;
  Kint::$display_called_from = $config->displayCalledFrom;

diff --git a/user_guide_src/source/installation/upgrade_450.rst b/user_guide_src/source/installation/upgrade_450.rst
@@ -106,6 +106,9 @@ Config
 - app/Config/Feature.php
  - ``Config\Feature::$multipleFilters`` has been removed, because now
  :ref:`multiple-filters` are always enabled.
+- app/Config/Kint.php
+ - It no longer extends ``BaseConfig`` because enabling
+ :ref:`factories-config-caching` could cause errors.
 
 All Changes
 ===========