Bill Cosponsor Card #1244
Open
Bill Cosponsor Card #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@akh4rf is attempting to deploy a commit to the Maple Testimony Team on Vercel. A member of the Team first needs to authorize it. |
sashamaryl
requested changes
Aug 13, 2023
There was a problem hiding this comment.
Hey Austin! Nice work so far!
Just a couple broad notes:
-
Look at building the graph elements as react components. And/or checkout react-chartjs library as an option.
-
The role-over popup is a great. Let's wait to do any more on it until we get input from the design team.
-
Work on the styling and the other sponsor card elements and states to bring it inline with the figma (figma section)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#832
VIdeo
Screen.Recording.2023-08-07.at.2.22.18.AM.mov
Checklist
Screenshots
Add some screenshots highlighting your changes.
Known issues
If you've run against limitations or caveats, include them here. Include follow-up issues as well.
Steps to test/reproduce
yarn storybook