Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Automatically collapse info section on user interaction #309

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

azheng1991
Copy link
Collaborator

No description provided.

@azheng1991
Copy link
Collaborator Author

Didn't see a way to leave comments on each individual file, so I'm leaving them in this format:

  1. for the change on frontend/.env, this was done so that the app worked locally on my machine as I had previously been receiving a noapi error
  2. frontend/src/ui/LandingBlurb/LandingBlurb.stories.tsx: this change was done in order to make landing blurb it's own folder directory because the landingblurb component within it needed to have a container so that we could change it's behavior upon selection of the occupation.
  3. frontend/src/ui/LandingBlurb/LandingBlurb.tsx: this change was made so that the landingblurb could be clicked to expand the title text (to keep the original behavior of being able to expand and collapse that blurb).
  4. frontend/src/ui/LandingBlurb/LandingBlurbContainer.tsx: this was the meat of the PR, the useEffect function in there was what was being used to change the behavior of the landingblurb container once the user had selected the occupation

As far as testing the changes, when I tried running npm start I got an error saying that LandingBlurbContainer didn't exist in the file structure of import { LandingBlurbContainer } from '../LandingBlurb', even though I definitely saw a LandingBlurbContainer.tsx file in that folder

@jedpittman
Copy link
Collaborator

jedpittman commented Feb 19, 2021 via email

Copy link
Collaborator

@jedpittman jedpittman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's more to do here to get this to a usable state. I'm reaching out via slack.

@jedpittman jedpittman changed the title progress with Alex WIP: progress with Alex Feb 20, 2021
@jedpittman jedpittman self-assigned this Mar 14, 2021
@alexjball alexjball changed the title WIP: progress with Alex WIP: Automatically collapse info section on user interaction Mar 27, 2021
@alexjball alexjball marked this pull request as draft March 27, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants