-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Automatically collapse info section on user interaction #309
base: develop
Are you sure you want to change the base?
Conversation
Didn't see a way to leave comments on each individual file, so I'm leaving them in this format:
As far as testing the changes, when I tried running npm start I got an error saying that LandingBlurbContainer didn't exist in the file structure of import { LandingBlurbContainer } from '../LandingBlurb', even though I definitely saw a LandingBlurbContainer.tsx file in that folder |
awesome. Thanks a bunch!
…On Fri, Feb 19, 2021 at 1:47 PM Allan Zheng ***@***.***> wrote:
Didn't see a way to leave comments on each individual file, so I'm leaving
them in this format:
1. for the change on frontend/.env, this was done so that the app
worked locally on my machine as I had previously been receiving a noapi
error
2. frontend/src/ui/LandingBlurb/LandingBlurb.stories.tsx: this change
was done in order to make landing blurb it's own folder directory because
the landingblurb component within it needed to have a container so that we
could change it's behavior upon selection of the occupation.
3. frontend/src/ui/LandingBlurb/LandingBlurb.tsx: this change was made
so that the landingblurb could be clicked to expand the title text (to keep
the original behavior of being able to expand and collapse that blurb).
4. frontend/src/ui/LandingBlurb/LandingBlurbContainer.tsx: this was
the meat of the PR, the useEffect function in there was what was being used
to change the behavior of the landingblurb container once the user had
selected the occupation
As far as testing the changes, when I tried running npm start I got an
error saying that LandingBlurbContainer didn't exist in the file structure
of import { LandingBlurbContainer } from '../LandingBlurb', even though I
definitely saw a LandingBlurbContainer.tsx file in that folder
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#309 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEMD2CR7QDHMEJZCWMBHWFLS72W3LANCNFSM4X2TA4ZQ>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's more to do here to get this to a usable state. I'm reaching out via slack.
No description provided.