Feature/mobile layout #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| }.bind(this), 50); | ||
| } | ||
| // var addition = 0; |
There was a problem hiding this comment.
@paulswartz I'm unsure how we should handle this in conjunction with a variable -width sidebar based on screen size. Maybe it's possible to adjust the "addition" via a class + media queries, which could get set based on what is enabled (list/facets)?
There was a problem hiding this comment.
That sounds like a good fix; add classes to the body when the panels are enabled, and use that to control the CSS.
…ggleable slide-out from full to mobile, add some comments and clean up css
… interaction with mobile sidebar then resizing
isaacchansky
force-pushed
the
feature/mobile-layout
branch
2 times, most recently
from
f169a0e
to
11f726f
Compare
isaacchansky
force-pushed
the
feature/mobile-layout
branch
from
11f726f
to
2567481
Compare
|
This is already way better than our current (non-existent) mobile interface. It's a little confusing that there are two hamburger icons; maybe have [list][filter][map] as always available buttons at the top? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First stab at designing/implementing a mobile experience.
Basically, it is more or less the same as now on desktop, smaller (tablet-ish) screens will get a tabbed sidebar that takes up less of the screen, and mobile will get an off-canvas sidebar that is togglable by a little button on the bottom right.
check it out here: http://www.isaacchansky.me/finda/