[CCAP-419] Removing flag for enabling background jobs (#702)

codeforamerica · Oct 17, 2024 · fe8e0ed · fe8e0ed
1 parent d8843bf
commit fe8e0ed
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 11 deletions.
diff --git a/src/main/java/org/ilgcc/app/config/DocumentTransferConfiguration.java b/src/main/java/org/ilgcc/app/config/DocumentTransferConfiguration.java
@@ -16,6 +16,5 @@ public class DocumentTransferConfiguration {
  public String authToken;
  public Long presignedUrlDuration;
  public String processingOrg;
- public String enableBackgroundJobs;
  public String waitForProviderResponse;
 }
diff --git a/...main/java/org/ilgcc/app/submission/actions/SendUploadedFileToDocumentTransferService.java b/...main/java/org/ilgcc/app/submission/actions/SendUploadedFileToDocumentTransferService.java
@@ -19,26 +19,23 @@ public class SendUploadedFileToDocumentTransferService implements Action {
  private final UserFileRepositoryService userFileRepositoryService;
  private final UploadedDocumentTransmissionJob uploadedDocumentTransmissionJob;
  private final S3PresignService s3PresignService;
- private final String enableBackgroundJobs;
  private final String waitForProviderResponseFlag;
 
  private final EnqueueDocumentTransfer enqueueDocumentTransfer;
 
  public SendUploadedFileToDocumentTransferService(UserFileRepositoryService userFileRepositoryService,
  UploadedDocumentTransmissionJob uploadedDocumentTransmissionJob, S3PresignService s3PresignService, EnqueueDocumentTransfer enqueueDocumentTransfer,
- @Value("${il-gcc.dts.enable-background-jobs}") String enableBackgroundJobs,
  @Value("${il-gcc.dts.wait-for-provider-response}") String waitForProviderResponseFlag) {
  this.userFileRepositoryService = userFileRepositoryService;
  this.uploadedDocumentTransmissionJob = uploadedDocumentTransmissionJob;
  this.s3PresignService = s3PresignService;
  this.enqueueDocumentTransfer = enqueueDocumentTransfer;
- this.enableBackgroundJobs = enableBackgroundJobs;
  this.waitForProviderResponseFlag=waitForProviderResponseFlag;
  }
 
  @Override
  public void run(Submission submission) {
- if (enableBackgroundJobs.equals("true") && waitForProviderResponseFlag.equals("false")) {
+ if (waitForProviderResponseFlag.equals("false")) {
  enqueueDocumentTransfer.enqueueUploadedDocumentBySubmission(userFileRepositoryService, uploadedDocumentTransmissionJob, s3PresignService, submission);
  }
  }

diff --git a/src/main/java/org/ilgcc/app/submission/actions/UploadSubmissionToS3.java b/src/main/java/org/ilgcc/app/submission/actions/UploadSubmissionToS3.java
@@ -24,26 +24,22 @@ public class UploadSubmissionToS3 implements Action {
 
  private final EnqueueDocumentTransfer enqueueDocumentTransfer;
 
- private final String enableBackgroundJobs;
-
  private final String waitForProviderResponseFlag;
 
  public UploadSubmissionToS3(PdfService pdfService, CloudFileRepository cloudFileRepository,
  PdfTransmissionJob pdfTransmissionJob,
  EnqueueDocumentTransfer enqueueDocumentTransfer,
- @Value("${il-gcc.dts.enable-background-jobs}") String enableBackgroundJobs,
  @Value("${il-gcc.dts.wait-for-provider-response}") String waitForProviderResponseFlag) {
  this.pdfService = pdfService;
  this.cloudFileRepository = cloudFileRepository;
  this.pdfTransmissionJob = pdfTransmissionJob;
  this.enqueueDocumentTransfer = enqueueDocumentTransfer;
- this.enableBackgroundJobs = enableBackgroundJobs;
  this.waitForProviderResponseFlag = waitForProviderResponseFlag;
  }
 
  @Override
  public void run(Submission submission) {
- if (enableBackgroundJobs.equals("true") && waitForProviderResponseFlag.equals("false")) {
+ if (waitForProviderResponseFlag.equals("false")) {
  enqueueDocumentTransfer.enqueuePDFDocumentBySubmission(pdfService, cloudFileRepository, pdfTransmissionJob,
  submission, FileNameUtility.getFileNameForPdf(submission));
  }

diff --git a/src/main/resources/application.yaml b/src/main/resources/application.yaml
@@ -118,5 +118,4 @@ il-gcc:
  consumer-id: ${DOCUMENT_TRANSFER_SERVICE_CONSUMER_ID}
  auth-token: ${DOCUMENT_TRANSFER_SERVICE_AUTH_TOKEN}
  presigned-url-Duration: 5 # Minutes
- enable-background-jobs: ${ENABLE_BACKGROUND_JOBS_FLAG:true}
  wait-for-provider-response: ${WAIT_FOR_PROVIDER_RESPONSE_FLAG:false}