Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #13

Merged
merged 5 commits into from
Feb 16, 2024
Merged

Dev #13

merged 5 commits into from
Feb 16, 2024

Conversation

ct-viral
Copy link
Member

Commit Checklist

  • Remove UNUSED comment code
  • Remove any logging like console.log
  • Remove all warnings and errors while build
  • Check vulnerabilities
  • Make sure build for production is working. Try running command for prod build in local.
  • Fix prettier: npx prettier --write .
  • Fix eslint: npx eslint src\ --fix command
  • Push package.lock only if you used npm, push yarn.lock only if you used yarn. NPM will udpate both lock file so make sure you dont push yarn.lock updated by NPM
  • WCAG

General

  • Follow import structure. module/third-party/files/component/style/types/asset
  • Try to use theme for design like palette, typography, variant, components, etc. (don't use custom color code anyhow)
  • Before adding custom style follow our pre-built components/elements

@ct-viral ct-viral merged commit d7fbda4 into stage Feb 16, 2024
@ct-viral ct-viral deleted the dev branch February 16, 2024 04:19
phoenixcoded20 added a commit that referenced this pull request Feb 21, 2024
* angular_17 upgrade

* code improvement compete

* update readme file complete

* new update done

* review change

* package.lock remove and yarn.lock add

* update banner images

* update license file and change update sidebar buy now link

* react free version complete

* update x tweet link and other theme buy link

* update react theme other theme buy now link

* Dev (#13)

* free theme

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update prod-bootstrap.yml

* Create README.md

* cicd for react

---------

Co-authored-by: mitax-nakrani-04 <[email protected]>
Co-authored-by: CodedThemes <[email protected]>
Co-authored-by: ct-viral <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant