add test for Receive Extension Handshake stage #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarp
commented
Sep 9, 2024
| @@ -34,12 +33,6 @@ func testMagnetSendExtendedHandshake(stageHarness *test_case_harness.TestCaseHar | |||
| if err = assertExitCode(result, 0); err != nil { | |||
| return err | |||
| } | |||
|
|
|||
| expected := fmt.Sprintf("Peer Metadata Extension ID: %d\n", params.MyMetadataExtensionID) | |||
There was a problem hiding this comment.
forgot to commit this in previous PR, we don't expect any output in this stage
rohitpaulk
approved these changes
Sep 10, 2024
sarp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of magnet links extension
It adds tests for receive extension handshake stage
Tester will validate that extension handshake was received by expecting correct "Peer Metadata Extension ID: xxx" in the output
Stages