Update logs to correspond to chosen executable & update tester-utils #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitpaulk
reviewed
Jun 17, 2024
internal/tester_definition.go
Outdated
| @@ -49,6 +50,7 @@ var testerDefinition = tester_definition.TesterDefinition{ | |||
| { | |||
| Slug: "nd2", | |||
| TestFunc: testDownloadPiece, | |||
| Timeout: 30 * time.Second, | |||
There was a problem hiding this comment.
@glokta1 we haven't needed this before - are you sure this is required? Does CI pass without it?
There was a problem hiding this comment.
@rohitpaulk Locally, the request to tracker URL kept timing out otherwise. I'll try pushing without the extra timeout and see if it works.
EDIT: Yeah, works on CI.
rohitpaulk
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to codecrafters-io/tester-utils#34