Creates the test for the SocketIO extension and adds it to the boot files #320
Conversation
…iles [socketio-jsb] add SocketIO JS extension test, update test menu and boot files [socketio-jsb] add socket.io client library to external sources [socketio-jsb] modify test to include getTag and setTag handlers [socketio-jsb] correct on handler declarations and streamline client tagging with a map of names and sockets [socketio-jsb] correct on handler declarations and streamline client tagging with a map of names and sockets [socketio-jsb] further streamline jsb vs js codes [socketio-jsb] remove sockets[] register in favor of tag property [socketio-jsb] correct identifier
| @@ -44,6 +44,7 @@ | |||
|
|
|||
| 'tests_resources-html5.js', | |||
| 'tests-main.js', | |||
| '../external/socket.io/socket.io.js', | |||
There was a problem hiding this comment.
Where was this file located? It's a module in cocos2d-html5?
There was a problem hiding this comment.
I will open a PR on the cocos2d-html5 repo to clarify, but yes you are
correct.
It is the compiled version from the root directory of the learnboost repo
here (although it looks like they just posted new version yesterday):
https://github.com/LearnBoost/socket.io-client
On Wed, Feb 26, 2014 at 12:39 AM, James Chen [email protected]:
In tests-boot-html5.js:
@@ -44,6 +44,7 @@
'tests_resources-html5.js', 'tests-main.js',
'../external/socket.io/socket.io.js',Where was this file located? It's a module in cocos2d-html5?
Reply to this email directly or view it on GitHubhttps://github.com//pull/320/files#r10069020
.
|
@dingpinglv |
[socketio-jsb] add SocketIO JS extension test, update test menu and boot files
[socketio-jsb] add socket.io client library to external sources
[socketio-jsb] modify test to include getTag and setTag handlers
[socketio-jsb] correct on handler declarations and streamline client tagging with a map of names and sockets
[socketio-jsb] correct on handler declarations and streamline client tagging with a map of names and sockets
[socketio-jsb] further streamline jsb vs js codes
[socketio-jsb] remove sockets[] register in favor of tag property
[socketio-jsb] correct identifier