Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed coala-analyzer to coala-eclipse #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

changed coala-analyzer to coala-eclipse #43

wants to merge 1 commit into from

Conversation

yukgupta
Copy link

fixes #33

@yukgupta
Copy link
Author

@yukiisbored My CI test is failing, where did I go wrong?

@mamat-rahmat
Copy link
Member

mamat-rahmat commented Nov 24, 2017 •
edited
Loading

Looks like an intermittent error. Nothing is wrong with your change.

mamat-rahmat
mamat-rahmat suggested changes Nov 24, 2017
View reviewed changes
Copy link
Member

@mamat-rahmat mamat-rahmat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tag with file that is modified, in front of your commit messsage.
And better rephrase to explain that it is changing build status url.

@mamat-rahmat
Copy link
Member

unack 8f88d56

@yukiisbored
Copy link
Member

@xyzyg Hello, it looks like a test failed. I'm gonna restart CI and please change your commit message by amending it. Refer to coala.io/commit for more information.

@yukiisbored
Copy link
Member

yukiisbored commented Nov 24, 2017 •
edited
Loading

Actually, I think one of the tests is broken.

@yukiisbored
Copy link
Member

yukiisbored commented Nov 24, 2017 •
edited
Loading

Gonna mark this as blocked. The same way #38 is handled.

@jayvdb jayvdb changed the title changed coala-analyzer to coala changed coala-analyzer to coala-eclipse Nov 27, 2017
@jayvdb
Copy link
Member

jayvdb commented Nov 27, 2017

The commit message is wrong shortlog and wrong Fixes.

@Monal5031
Copy link
Member

@xyzyg Please assign yourself to the issue before working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamat-rahmat mamat-rahmat mamat-rahmat requested changes

Assignees
No one assigned
Labels
difficulty/newcomer process/wip size/XS status/blocked
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change README Travis Badge link
6 participants
@yukgupta @mamat-rahmat @yukiisbored @jayvdb @Monal5031 @gitmate-bot