Added more ZDC functionality to DQM #46478
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46478/42334 |
|
A new Pull Request was created by @cfmcginn for master. It involves the following packages:
@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
| process.load("Configuration.StandardSequences.FrontierConditions_GlobalTag_cff") | ||
| process.GlobalTag.globaltag = autoCond['run3_data_prompt'] | ||
| process.load("Configuration.StandardSequences.FrontierConditions_GlobalTag_cff") | ||
| process.GlobalTag.globaltag = '141X_dataRun3_Prompt_Candidate_2024_10_08_09_42_50' |
There was a problem hiding this comment.
none of the comments of the 14.1.X backport was addressed.
There was a problem hiding this comment.
I opted to get this up such that it was faithful to the backport version code - happy to address the comments now, will go thru and recommit
There was a problem hiding this comment.
Adding: I will go thru and update this PR and the backport simultaneously
There was a problem hiding this comment.
Responded issue-by-issue in backport thread, all suggestions adopted, both PRs updated
cmsbuild
added
tests-pending
code-checks-pending
and removed
tests-started
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46478/42338 |
|
Pull request #46478 was updated. @antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again. |
PR description:
This PR is to replace existing, closed PR here: #45948
The PR adds to the DQM for ZDC specific histograms, via ZDCQIE10Task
This PR is updated relative to the closed previous PR, mostly fixing build issue, retitling some histograms, and updating python such that emulated ZDC sums fill. Another PR exists where it is rebased to 14_1_X for backport, currently open here #46407.
PR validation:
The PR is tested in CMSSW_14_2_X_2024-10-20-0000, after running a merge-topic to incorporate the PR into a fresh area
scram b ran successfully, validating the build
Following test command produces the expected output:
under the upload directory, if using the offline candidate GT. Inspected histograms inside the DQM file appear reasonable for ZDC sums.
In addition, the following set of commands are run
scram b runtests
scram build code-checks
scram build code-format
code-checks revealed no issues, code-format offered no suggestions. runtests had multiple failures, detailed below - however, every failure existed already with runtests in a fresh area, and matches the set of failures documented already in the backport. As such, it is unclear the failures are the result of the PR
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
As mentioned above, this PR is to replace the closed PR #45948, and is paired to the backport to CMSSW_14_1_X, found here #46407