docker: fix build not setting bin version

clusterise · Jul 8, 2018 · c886d51 · c886d51
1 parent 99590ac
commit c886d51
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -1,11 +1,13 @@
 FROM golang:1.10-alpine3.7 as build
 
+ARG VERSION
+
 WORKDIR /go/src/github.com/Mikulas/kubectl-repl
 ADD . /go/src/github.com/Mikulas/kubectl-repl/
 RUN apk update && \
     apk add --no-cache \
         ca-certificates curl git make && \
-    make build && \
+    make build VERSION=$VERSION && \
     curl -LO https://storage.googleapis.com/kubernetes-release/release/$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)/bin/linux/amd64/kubectl && \
     chmod +x ./kubectl
 

diff --git a/Makefile b/Makefile
@@ -25,6 +25,6 @@ release:
 
 docker:
 	rm kubectl-repl || true
-	docker build -t ${REPO}:${VERSION} .
+	docker build --build-arg VERSION=${VERSION} -t ${REPO}:${VERSION} .
 
 .PHONY: docker preflight