Edge config gui #8
Conversation
Danielv123
force-pushed
the
edge-config-gui
branch
from
9a15e5a
to
879137b
Compare
Danielv123
force-pushed
the
edge-config-gui
branch
from
167f40f
to
fd61346
Compare
|
This is now working with the latest master branch of clusterio. I consider this PR fully featured at this point, although I think we should consider making changes to the edge transports config system in the future. Currently edges are configured as part of the instance configuration, but this poses an obvious problem - which instance does an edge belong to? Since they are bidirectional they need to be configured on both the target and destination instance. You end up with 2 sources of truth which can conflict. I propose pulling edge configurations out of the instance configurations. Instead, Id have edges be configured in a separate datastore with partner 1 and 2 (order not significant) being defined in the same json object and the changes being propagated to all partner instances. This might also help simplify and alleviate the issues that exist today with updating and synchronizing edge configuration and status like #7 |
| value={edge.origin?.[0]} | ||
| formatter={(value) => `x ${value}`} | ||
| parser={value => value.replace("x ", "")} | ||
| onChange={(value) => onChange({ ...edge, origin: [value, edge.origin?.[1]] })} |
There was a problem hiding this comment.
Will an edge ever not have an origin? Within onChange this would result in [value, undefined] which seans like it would only cause more errors.
There was a problem hiding this comment.
It never had an origin before I defaulted it to have one. It can still not have one if defined manually using the cli for example. This pattern is required to input the array properly. If we want to avoid undefined to end up in the config like that we need a validation guard on the top level save function, not here.
Edge transports adoption is ~0, largely due to lacking discoverability and cumbersome configuration (I presume). This PR utilizes the inputComponent plugin functionality that was added alongside modpack support 4 months ago to create a configuration popup aimed to provide as much guidance through the process and catching configuration issues as early as possible.