Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying variable types using named parameter types #547

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ejholmes
Copy link
Contributor

@ejholmes ejholmes commented Mar 1, 2018

Closes #546

This just makes it a little easier to use CFNType's, by just specifying the name of the type you want for the parameter. The following now works:

VARIABLES = {
    "VpcId": {
        "type": "AWS::EC2::VPC::Id"
    }   
}

And it'll be automatically normalized to:

VARIABLES = {
    "VpcId": {
        "type": EC2VPCId
    }
}

@ejholmes ejholmes requested a review from phobologic March 1, 2018 07:35
@ejholmes ejholmes added this to the 1.3 milestone Mar 1, 2018
Copy link
Member

@phobologic phobologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - needs docs.

"""Looks for any variable definitions that are a "str", and assumes that
they're the name of a CloudFormation parameter type, in which case the type
is converted to a CFNType.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs Args

@ejholmes ejholmes removed this from the 1.3 milestone Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants