chore: Use @cloudscape-design/build-tools stylelint rules #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldowseza
temporarily deployed
to
dev-pages
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 348 348
Branches 31 31
=========================================
Hits 348 348 ☔ View full report in Codecov by Sentry. |
michaeldowseza
force-pushed
the
chore/build-tools
branch
from
e910e9e
to
7ba2d9a
Compare
michaeldowseza
requested review from
just-boris
and removed request for
a team
just-boris
reviewed
Oct 11, 2024
| @@ -74,6 +74,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@cloudscape-design/browser-test-tools": "^3.0.4", | |||
| "@cloudscape-design/build-tools": "^3.0.1", | |||
There was a problem hiding this comment.
Not directly related to your PR, but should we align all @cloudscape-design dependencies versions here?
There was a problem hiding this comment.
Do you mean align them to ^3.0.0?
just-boris
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use stylelint rules from shared cloudscape-design/build-tools package.
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.