Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Import sort plugin #37

Merged
merged 4 commits into from
Jul 24, 2024
Merged

chore: Import sort plugin #37

merged 4 commits into from
Jul 24, 2024

Conversation

georgylobko
Copy link
Contributor

Description

Introduced a new plugin to group and alphabetically sort imports in the following order:

external packages
cloudscape packages
internal imports
styles

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (65c7642) to head (3cf2cc4).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #37   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          319       345   +26     
  Branches        30        30           
=========================================
+ Hits           319       345   +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgylobko georgylobko marked this pull request as ready for review July 18, 2024 12:14
@georgylobko georgylobko requested a review from a team as a code owner July 18, 2024 12:14
@georgylobko georgylobko requested review from orangevolon and removed request for a team July 18, 2024 12:14
.eslintrc Show resolved Hide resolved
pages/main.tsx Show resolved Hide resolved
@georgylobko georgylobko merged commit 7b02ed3 into main Jul 24, 2024
33 checks passed
@georgylobko georgylobko deleted the chore/eslint-import-sort branch July 24, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants