fix: Fix type name clashing & nullability issues #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candiduslynx
force-pushed
the
fix/use-pkg-path-jsonschema
branch
from
23d0801
to
2efbf05
Compare
candiduslynx
force-pushed
the
fix/use-pkg-path-jsonschema
branch
from
d34d419
to
6ff050b
Compare
candiduslynx
changed the title
disq
approved these changes
Oct 6, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
🤖 I have created a release *beep* *boop* --- ## [0.3.5](v0.3.4...v0.3.5) (2023-10-06) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.1 ([#40](#40)) ([98aa56c](98aa56c)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.2 ([#42](#42)) ([7e845b6](7e845b6)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.3 ([#43](#43)) ([b537cc6](b537cc6)) * Fix type name clashing & nullability issues ([#39](#39)) ([6940313](6940313)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Oct 6, 2023
Closes #14027 Blocked by: * cloudquery/codegen#39 * invopop/jsonschema#109 – merged to `cloudquery/jsonschema@cqmain` * invopop/jsonschema#110 – merged to `cloudquery/jsonschema@cqmain` I propose reviewing the annotations along with tests, as the JSON schemas generated are just too long to grasp visually.
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
Closes cloudquery#14027 Blocked by: * cloudquery/codegen#39 * invopop/jsonschema#109 – merged to `cloudquery/jsonschema@cqmain` * invopop/jsonschema#110 – merged to `cloudquery/jsonschema@cqmain` I propose reviewing the annotations along with tests, as the JSON schemas generated are just too long to grasp visually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by:
NullableFromTypeoption invopop/jsonschema#110