-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refac/organization standardization #650
base: main
Are you sure you want to change the base?
Conversation
918cca6
to
4ca9c82
Compare
} | ||
|
||
// Ignore organizations without OIDC configuration. | ||
if org.Spec.Authentication == nil || org.Spec.Authentication.OIDCConfig == nil { | ||
return ctrl.Result{}, nil | ||
return ctrl.Result{}, lifecycle.Pending, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is Pending
being returned so that the Ready
status is not set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, I switched to lifecycle.Success in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I move it to the predicate to filter reconciliation.
We should merge all 3 controllers into one since they are acting on the same Custom Resource. With current approach there will be conflict with if no OIDC config is provided then it will be There will be potentially an infinite loop where the competing controllers will put You can merge all 3 functionalities into one Organization Reconciler and the logical order can be -
But since the issue states you donβt need to consolidate at this point we need to bring this up in core dev meeting to check with others |
Let's go with a |
30fc606
to
430e89d
Compare
β¦ return success (#583)
6d4f2c2
to
769a93f
Compare
β¦ return success (#583)
f8a3ee8
to
7309a28
Compare
404a887
to
aa81531
Compare
Description
I implement new approach to the organization controllers.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist