Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFAC] - Standardise Organisation controllers #583

Open
4 tasks
Tracked by #544
IvoGoman opened this issue Sep 17, 2024 · 0 comments · May be fixed by #650
Open
4 tasks
Tracked by #544

[REFAC] - Standardise Organisation controllers #583

IvoGoman opened this issue Sep 17, 2024 · 0 comments · May be fixed by #650
Assignees

Comments

@IvoGoman
Copy link
Contributor

IvoGoman commented Sep 17, 2024

As part of the standardisation of the reconciliation loop for Greenhouse controllers, these controllers need to be updated to follow the common recommendation for the Reconciliation. This includes DexController, OrganizationController, RBACController, ServiceProxyController, TeamRoleSeederController.

It is not required to consolidate these controllers at this point.

Acceptance Criteria

  • Implement the Interface
  • Use the standardised patch for updating the status instead of the deferred update (if applicable)
  • Convert the tests to use test.TestSetup (if applicable) including creation of missing resources
  • Remove dedicated finalizers used on the controllers because they are replaced with standard ones.
@IvoGoman IvoGoman changed the title [FEAT] - Standardise Organisation controllers [REFAC] - Standardise Organisation controllers Sep 17, 2024
@gciezkowski-acc gciezkowski-acc linked a pull request Oct 21, 2024 that will close this issue
26 tasks
gciezkowski-acc added a commit that referenced this issue Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Sprint Backlog
Development

Successfully merging a pull request may close this issue.

2 participants