Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix roleName & specify region as variable #3887

Merged
merged 1 commit into from
Oct 26, 2024
Merged

fix roleName & specify region as variable #3887

merged 1 commit into from
Oct 26, 2024

Conversation

ShotaKitazawa
Copy link
Member

Description

Fixes # (issue)

Type of change

  • Document update or simple typo fix
  • Maintenance/update components
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • I have checked backward/forward compatibility that may cause regarding this change.

Copy link

✅ Preview for stg

Copy link

✅ Preview for prod
--- arn:aws:ecs:ap-northeast-1:607167088920:task-definition/dreamkast-prod-seaman:24
+++ prod/seaman/task-def.jsonnet
@@ -90,7 +90,6 @@
   "taskRoleArn": "arn:aws:iam::607167088920:role/dreamkast-prod-ecs-seaman",
   "volumes": [
     {
-      "host": {},
       "name": "config"
     }
   ]

@takaishi takaishi merged commit 1621387 into main Oct 26, 2024
3 checks passed
@takaishi takaishi deleted the prod_bugfix branch October 26, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants