-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default wrangler version to 3.x #238
Open
Eusebiotrigo
wants to merge
5
commits into
cloudflare:main
Choose a base branch
from
Eusebiotrigo:update/wrangler-to-3.30.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1d28a05
Update default wrangler version to 3.30.0
Eusebiotrigo a99a395
Update default wrangler version to 3.37.0
Eusebiotrigo b959cd2
Adding changeset
Eusebiotrigo 888649c
Update default wrangler version to 3.52.0
Eusebiotrigo 9580f80
feature: Set DEFAULT_WRANGLER_VERSION to 3.x
petebacondarwin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
--- | ||
"wrangler-action": minor | ||
--- | ||
|
||
feature: Set DEFAULT_WRANGLER_VERSION to 3.x | ||
|
||
This will ensure that wrangler-action will use the latest compatible version of Wrangler if not specified otherwise. | ||
|
||
There are two ways to lock down the version of Wrangler for this action: | ||
|
||
- Specify the required version in the action's parameters when implementing it in your Github Workflows. | ||
- Add a dependency to a specific version in your package.json of the project being deployed via this action. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Urgh! We can't set this to a range because we need to compare it with other semantic versions.
We could just go with
latest
here...?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latest
would potentially introduce a breaking chance once 4.x is out though, wouldn't it, if people are just relying on the defaults?Perhaps looking up the versions on npm and pulling the latest 3.x from there would be best as a first step? If there was a
v3
tag, it could be as simple as (pseudo-example)curl https://registry.npmjs.org/wrangler | jq '.["dist-tags"].v3'
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I briefly played around with looking up the version but it is a bit messy especially if there is no dist-tag, since we would have to iterate over all the versions and find one that best matches the version range.