Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default wrangler version to 3.x #238

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .changeset/twenty-beans-compare.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
"wrangler-action": minor
---

feature: Set DEFAULT_WRANGLER_VERSION to 3.x

This will ensure that wrangler-action will use the latest compatible version of Wrangler if not specified otherwise.

There are two ways to lock down the version of Wrangler for this action:

- Specify the required version in the action's parameters when implementing it in your Github Workflows.
- Add a dependency to a specific version in your package.json of the project being deployed via this action.
2 changes: 1 addition & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { exec, execShell } from "./exec";
import { checkWorkingDirectory, semverCompare } from "./utils";
import { getPackageManager } from "./packageManagers";

const DEFAULT_WRANGLER_VERSION = "3.13.2";
const DEFAULT_WRANGLER_VERSION = "3.x";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Urgh! We can't set this to a range because we need to compare it with other semantic versions.

We could just go with latest here...?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest would potentially introduce a breaking chance once 4.x is out though, wouldn't it, if people are just relying on the defaults?

Perhaps looking up the versions on npm and pulling the latest 3.x from there would be best as a first step? If there was a v3 tag, it could be as simple as (pseudo-example) curl https://registry.npmjs.org/wrangler | jq '.["dist-tags"].v3'.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I briefly played around with looking up the version but it is a bit messy especially if there is no dist-tag, since we would have to iterate over all the versions and find one that best matches the version range.


/**
* A configuration object that contains all the inputs & immutable state for the action.
Expand Down
Loading