Quiet feature #154
Merged
Quiet feature #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1000hz
previously requested changes
Aug 11, 2023
1000hz
reviewed
Aug 11, 2023
JacobMGEvans
force-pushed
the
jacobmgevans/silence-mode
branch
2 times, most recently
from
df2c9a0
to
d246000
Compare
RamIdeas
reviewed
Aug 15, 2023
RamIdeas
reviewed
Aug 15, 2023
JacobMGEvans
force-pushed
the
jacobmgevans/silence-mode
branch
from
f704a8b
to
3974747
Compare
RamIdeas
approved these changes
Aug 16, 2023
penalosa
reviewed
Aug 16, 2023
JacobMGEvans
force-pushed
the
jacobmgevans/silence-mode
branch
from
3974747
to
af4153a
Compare
JacobMGEvans
dismissed
1000hz’s stale review
OOO and have alternative approval
Some of the stderr, stdout, info & groupings can be a little noisy for some users and use cases. This feature allows for a option to be passed 'quiet: true' this would significantly reduce the noise. There will still be output that lets the user know Wrangler Installed and Wrangler Action completed successfully. Any failure status will still be output to the user as well, to prevent silent failures. resolves #142
JacobMGEvans
force-pushed
the
jacobmgevans/silence-mode
branch
from
af4153a
to
3f40637
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the stderr, stdout, info & groupings can be a little noisy for some users and use cases. This feature allows for a option to be passed 'quiet: true' this would significantly reduce the noise.
There will still be output that lets the user know Wrangler Installed and Wrangler Action completed successfully. Any failure status will still be output to the user as well, to prevent silent failures.
resolves #142
